[flang-commits] [flang] [flang] Catch ASSOCIATE(x=>assumed_rank) (PR #100626)
via flang-commits
flang-commits at lists.llvm.org
Thu Jul 25 11:20:46 PDT 2024
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-flang-semantics
Author: Peter Klausler (klausler)
<details>
<summary>Changes</summary>
An assumed-rank dummy argument cannot be the variable or expression in the selector of an ASSOCIATE construct. (SELECT TYPE/RANK are fine.)
---
Full diff: https://github.com/llvm/llvm-project/pull/100626.diff
2 Files Affected:
- (modified) flang/lib/Semantics/resolve-names.cpp (+5-1)
- (added) flang/test/Semantics/associate04.f90 (+7)
``````````diff
diff --git a/flang/lib/Semantics/resolve-names.cpp b/flang/lib/Semantics/resolve-names.cpp
index f761355d0da32..6a4482c51a5f8 100644
--- a/flang/lib/Semantics/resolve-names.cpp
+++ b/flang/lib/Semantics/resolve-names.cpp
@@ -7118,9 +7118,13 @@ void ConstructVisitor::Post(const parser::AssociateStmt &x) {
for (auto nthLastAssoc{assocCount}; nthLastAssoc > 0; --nthLastAssoc) {
SetCurrentAssociation(nthLastAssoc);
if (auto *symbol{MakeAssocEntity()}) {
- if (ExtractCoarrayRef(GetCurrentAssociation().selector.expr)) { // C1103
+ const MaybeExpr &expr{GetCurrentAssociation().selector.expr};
+ if (ExtractCoarrayRef(expr)) { // C1103
Say("Selector must not be a coindexed object"_err_en_US);
}
+ if (evaluate::IsAssumedRank(expr)) {
+ Say("Selector must not be assumed-rank"_err_en_US);
+ }
SetTypeFromAssociation(*symbol);
SetAttrsFromAssociation(*symbol);
}
diff --git a/flang/test/Semantics/associate04.f90 b/flang/test/Semantics/associate04.f90
new file mode 100644
index 0000000000000..5a73ba419c0a3
--- /dev/null
+++ b/flang/test/Semantics/associate04.f90
@@ -0,0 +1,7 @@
+! RUN: %python %S/test_errors.py %s %flang_fc1
+subroutine bad(a)
+ real :: a(..)
+ !ERROR: Selector must not be assumed-rank
+ associate(x => a)
+ end associate
+end subroutine
``````````
</details>
https://github.com/llvm/llvm-project/pull/100626
More information about the flang-commits
mailing list