[flang-commits] [flang] [mlir] [MLIR][OpenMP][Flang] Normalize clause arguments names (PR #99505)

[Sergio Afonso via flang-commits]

================
@@ -32,37 +32,37 @@ namespace omp {
 
 struct AlignedClauseOps {
   llvm::SmallVector<Value> alignedVars;
-  llvm::SmallVector<Attribute> alignmentAttrs;
+  llvm::SmallVector<Attribute> alignments;
 };
 
 struct AllocateClauseOps {
-  llvm::SmallVector<Value> allocatorVars, allocateVars;
+  llvm::SmallVector<Value> allocateVars, allocatorVars;
 };
 
 struct CancelDirectiveNameClauseOps {
-  ClauseCancellationConstructTypeAttr cancelDirectiveNameAttr;
+  ClauseCancellationConstructTypeAttr cancelDirective;
 };
 
 struct CollapseClauseOps {
-  llvm::SmallVector<Value> loopLBVar, loopUBVar, loopStepVar;
+  llvm::SmallVector<Value> collapseLowerBound, collapseUpperBound, collapseStep;
----------------
skatrak wrote:

Yes, I added the "collapse" prefix in reference to the clause name. Leaving them in singular was an oversight, thank you for pointing that out.

I get your point, but I'd prefer to try prefixing their name with something. I just want to avoid some "steps" clause to appear somewhere else and potentially collide. What do you think about `collapseAffectedLowerBounds`, `collapseAffectedUpperBounds`, `collapseAffectedSteps`?

https://github.com/llvm/llvm-project/pull/99505