[flang-commits] [flang] [flang][OpenMP] Enable lastprivate with collapse (PR #93778)
via flang-commits
flang-commits at lists.llvm.org
Thu Jul 18 07:47:41 PDT 2024
NimishMishra wrote:
> Hi, just removing the current check doesn't quite do the right thing, as the value of the lastprivate variable will be a random one of the last values of the inner loops, rather than the definite final one. To implement this we need to check that we have reached the final value of _all_ the loop indices, not just the outer one.
>
> I've submitted a patch with this approach here: #99500
Hi @DavidTruby
Thanks for the PR. I see what you mean. I'll close this then.
I've an internal reprioritization for a few days; I do plan to return to working on this and implementing the delayed privatization approach, as comments here (and your PR) mention. But in the meantime, we can go ahead with your PR.
https://github.com/llvm/llvm-project/pull/93778
More information about the flang-commits
mailing list