[flang-commits] [flang] [AMDGPU] Fix flang build after #97633 (PR #98231)
via flang-commits
flang-commits at lists.llvm.org
Tue Jul 9 14:52:23 PDT 2024
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-flang-driver
Author: Stanislav Mekhanoshin (rampitec)
<details>
<summary>Changes</summary>
---
Full diff: https://github.com/llvm/llvm-project/pull/98231.diff
1 Files Affected:
- (modified) flang/lib/Frontend/CompilerInstance.cpp (+4-4)
``````````diff
diff --git a/flang/lib/Frontend/CompilerInstance.cpp b/flang/lib/Frontend/CompilerInstance.cpp
index 27c36b7f84d89..d37430e0e5773 100644
--- a/flang/lib/Frontend/CompilerInstance.cpp
+++ b/flang/lib/Frontend/CompilerInstance.cpp
@@ -212,7 +212,6 @@ getExplicitAndImplicitAMDGPUTargetFeatures(clang::DiagnosticsEngine &diags,
const llvm::Triple triple) {
llvm::StringRef cpu = targetOpts.cpu;
llvm::StringMap<bool> implicitFeaturesMap;
- std::string errorMsg;
// Get the set of implicit target features
llvm::AMDGPU::fillAMDGPUFeatureMap(cpu, triple, implicitFeaturesMap);
@@ -222,11 +221,12 @@ getExplicitAndImplicitAMDGPUTargetFeatures(clang::DiagnosticsEngine &diags,
implicitFeaturesMap[userKeyString] = (userFeature[0] == '+');
}
- if (!llvm::AMDGPU::insertWaveSizeFeature(cpu, triple, implicitFeaturesMap,
- errorMsg)) {
+ auto HasError =
+ llvm::AMDGPU::insertWaveSizeFeature(cpu, triple, implicitFeaturesMap);
+ if (HasError.first) {
unsigned diagID = diags.getCustomDiagID(clang::DiagnosticsEngine::Error,
"Unsupported feature ID: %0");
- diags.Report(diagID) << errorMsg.data();
+ diags.Report(diagID) << HasError.second;
return std::string();
}
``````````
</details>
https://github.com/llvm/llvm-project/pull/98231
More information about the flang-commits
mailing list