[flang-commits] [flang] [Flang][OpenMP] Refactor loop-related lowering for composite support (PR #97566)
Sergio Afonso via flang-commits
flang-commits at lists.llvm.org
Fri Jul 5 03:18:54 PDT 2024
================
@@ -1492,7 +1466,7 @@ genParallelOp(lower::AbstractConverter &converter, lower::SymMap &symTable,
firOpBuilder.createBlock(®ion, /*insertPt=*/{}, allRegionArgTypes,
allRegionArgLocs);
- llvm::SmallVector<const semantics::Symbol *> allSymbols = reductionSyms;
+ llvm::SmallVector<const semantics::Symbol *> allSymbols(reductionSyms);
----------------
skatrak wrote:
I made the change here and in other places touched by this patch. However, I just noticed this in the coding standards guide: https://llvm.org/docs/CodingStandards.html#do-not-use-braced-initializer-lists-to-call-a-constructor. My understanding is that "function-like" syntax is preferred unless it's some kind of aggregate initialization.
https://github.com/llvm/llvm-project/pull/97566
More information about the flang-commits
mailing list