[flang-commits] [clang] [flang] [Flang-new][OpenMP] Add bitcode files for AMD GPU OpenMP (PR #96742)

Andrzej WarzyƄski via flang-commits flang-commits at lists.llvm.org
Fri Jul 5 00:37:46 PDT 2024


================
@@ -8024,7 +8024,7 @@ def source_date_epoch : Separate<["-"], "source-date-epoch">,
 // CUDA Options
 //===----------------------------------------------------------------------===//
 
-let Visibility = [CC1Option] in {
+let Visibility = [CC1Option, FC1Option] in {
----------------
banach-space wrote:

This enables 4 CUDA flags in `flang-new -fc1` - this really shouldn't be needed in this PR. I would expect that AMD GPU and CUDA logic to be orthogonal. If that's not the case, then lets try to either fix or at document that.

I appreciate that some sub-optimal behaviour might be inherited from Clang. In such cases, lets try to:
1.  Understand what's going on.
2. If a path towards a fix is clear, lets just fix it.
3. If there's no easy fix, lets document this with a GitHub issue and add a link in the commit/code.

Thanks!

https://github.com/llvm/llvm-project/pull/96742


More information about the flang-commits mailing list