[flang-commits] [flang] [flang] Improve warnings for invalid arguments when folding host runtime (PR #96807)

[LLVM Continuous Integration via flang-commits]

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `flang-aarch64-libcxx` running on `linaro-flang-aarch64-libcxx` while building `flang` at step 5 "build-unified-tree".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/89/builds/1285

Here is the relevant piece of the build log for the reference:
```
Step 5 (build-unified-tree) failure: build (failure)
...
147.947 [39/2/7050] Creating library symlink lib/libFIRCodeGen.so
148.217 [38/2/7051] Linking CXX shared library lib/libFIRTransforms.so.19.0git
148.223 [37/2/7052] Creating library symlink lib/libFIRTransforms.so
148.471 [35/3/7053] Linking CXX shared library lib/libFIRTestAnalysis.so.19.0git
148.478 [34/3/7054] Creating library symlink lib/libFIRTestAnalysis.so
148.791 [34/2/7055] Linking CXX shared library lib/libHLFIRTransforms.so.19.0git
148.797 [33/2/7056] Creating library symlink lib/libHLFIRTransforms.so
149.455 [31/3/7057] Linking CXX executable bin/tco
149.535 [31/2/7058] Linking CXX executable bin/fir-opt
172.840 [31/1/7059] Building CXX object tools/flang/lib/Evaluate/CMakeFiles/obj.FortranEvaluate.dir/intrinsics-library.cpp.o
FAILED: tools/flang/lib/Evaluate/CMakeFiles/obj.FortranEvaluate.dir/intrinsics-library.cpp.o 
/usr/local/bin/c++ -DFLANG_INCLUDE_TESTS=1 -DFLANG_LITTLE_ENDIAN=1 -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/tcwg-buildbot/worker/flang-aarch64-libcxx/build/tools/flang/lib/Evaluate -I/home/tcwg-buildbot/worker/flang-aarch64-libcxx/llvm-project/flang/lib/Evaluate -I/home/tcwg-buildbot/worker/flang-aarch64-libcxx/llvm-project/flang/include -I/home/tcwg-buildbot/worker/flang-aarch64-libcxx/build/tools/flang/include -I/home/tcwg-buildbot/worker/flang-aarch64-libcxx/build/include -I/home/tcwg-buildbot/worker/flang-aarch64-libcxx/llvm-project/llvm/include -isystem /home/tcwg-buildbot/worker/flang-aarch64-libcxx/llvm-project/llvm/../mlir/include -isystem /home/tcwg-buildbot/worker/flang-aarch64-libcxx/build/tools/mlir/include -isystem /home/tcwg-buildbot/worker/flang-aarch64-libcxx/build/tools/clang/include -isystem /home/tcwg-buildbot/worker/flang-aarch64-libcxx/llvm-project/llvm/../clang/include -stdlib=libc++ -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -Werror -Wno-deprecated-copy -Wno-string-conversion -Wno-ctad-maybe-unsupported -Wno-unused-command-line-argument -Wstring-conversion           -Wcovered-switch-default -Wno-nested-anon-types -O3 -DNDEBUG  -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -std=c++17 -MD -MT tools/flang/lib/Evaluate/CMakeFiles/obj.FortranEvaluate.dir/intrinsics-library.cpp.o -MF tools/flang/lib/Evaluate/CMakeFiles/obj.FortranEvaluate.dir/intrinsics-library.cpp.o.d -o tools/flang/lib/Evaluate/CMakeFiles/obj.FortranEvaluate.dir/intrinsics-library.cpp.o -c /home/tcwg-buildbot/worker/flang-aarch64-libcxx/llvm-project/flang/lib/Evaluate/intrinsics-library.cpp
../llvm-project/flang/lib/Evaluate/intrinsics-library.cpp:810:17: error: use of bitwise '&' with boolean operands [-Werror,-Wbitwise-instead-of-logical]
  810 |   return (... & F(args, context));
      |           ~~~   ^~~~~~~~~~~~~~~~
      |           &&
../llvm-project/flang/lib/Evaluate/intrinsics-library.cpp:828:9: note: in instantiation of function template specialization 'Fortran::evaluate::CombineVerifiers<&Fortran::evaluate::VerifyStrictlyPositiveIfReal, &Fortran::evaluate::VerifyNotZeroIfComplex>' requested here
  828 |         CombineVerifiers<VerifyStrictlyPositiveIfReal<firstArg, xName>,
      |         ^
../llvm-project/flang/lib/Evaluate/intrinsics-library.cpp:810:17: note: cast one or both operands to int to silence this warning
  810 |   return (... & F(args, context));
      |                 ^
1 error generated.
ninja: build stopped: subcommand failed.

```

https://github.com/llvm/llvm-project/pull/96807