[flang-commits] [flang] [flang][OpenMP] Fix nested privatization of allocatable (PR #96968)

[Kiran Chandramohan via flang-commits]

https://github.com/kiranchandramohan approved this pull request.

LG. Thanks for the fix.

I checked the delayed privatization flow for the parallel testcase and see that it fails currently.

```./bin/flang-new -emit-hlfir -fopenmp -mmlir --openmp-enable-delayed-privatization delayed.f90```

```
integer,pointer :: iii2
character(5),pointer :: cha2

allocate(iii2,cha2)
iii2 = 100
cha2 = "abcde"

!$omp parallel default(firstprivate)
!$omp parallel default(firstprivate)
  if ( iii2 .ne. 100 ) print *,'ng'
  if ( cha2 .ne. 'abcde' ) print *,'ng'
!$omp end parallel
!$omp end parallel
print *,'ok'
end
```

```
flang-new: /home/kircha02/llvm-project/flang/include/flang/Optimizer/Builder/BoxValue.h:376: fir::MutableBoxValue::MutableBoxValue(mlir::Value, mlir::ValueRange, MutableProperties): Assertion `verify() && "MutableBoxValue requires mem ref to fir.box<fir.[heap|ptr]<type>>"' failed.
PLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/ and include the crash backtrace.
```

https://github.com/llvm/llvm-project/pull/96968