[flang-commits] [clang] [flang] [Flang-new][OpenMP] Add bitcode files for AMD GPU OpenMP (PR #96742)

[Dominik Adamski via flang-commits]

================
@@ -333,6 +333,9 @@ void Flang::AddAMDGPUTargetArgs(const ArgList &Args,
     StringRef Val = A->getValue();
     CmdArgs.push_back(Args.MakeArgString("-mcode-object-version=" + Val));
   }
+
+  const ToolChain &TC = getToolChain();
+  TC.addClangTargetOptions(Args, CmdArgs, Action::OffloadKind::OFK_OpenMP);
----------------
DominikAdamski wrote:

> It's OK to make Flang "stricter" if we believe that's the right thing to do ;-) (I think that generating useful error/warning messages like "don't mix these flags - that's not supporter" would be a good thing)

Shall I extend https://github.com/llvm/llvm-project/pull/94763 ? I don't use `-fcuda-is-device` anymore. Now, I'm only adding `-mlink-builtin-bitcode` flags to `flang-new -fc1` command. The `-mlink-builtin-bitcode` option was introduced by https://github.com/llvm/llvm-project/pull/94763



> > IMO can be reused between Flang and Clang
> 
> Are there any plans to extract that logic and share it somewhere?

Not yet (at least from my side).  I can return to this topic if there is need to support Clang option by Flang for AMD GPU.



> > I don't know if Nvidia also want to reuse their toolchain between Clang and Flang to fully support OpenMP offloading.
> 
> Who could be the right person to ask?

I don't know. Open-source LLVM Flang meetings can be good  place to ask this question.

https://github.com/llvm/llvm-project/pull/96742