[flang-commits] [flang] [flang][cuda] Do not register global constants (PR #118582)

[Valentin Clement バレンタイン クレメン via flang-commits]

================
@@ -106,8 +106,7 @@ struct CUFAddConstructor
 
         mlir::func::FuncOp func;
         switch (attr.getValue()) {
-        case cuf::DataAttribute::Device:
-        case cuf::DataAttribute::Constant: {
+        case cuf::DataAttribute::Device: {
----------------
clementval wrote:

> Maybe we only apply the attribute to reflect the user setting?

Yeah it's probably nicer and if we need we can add an `implicit` attribute or just default to `device`.  I guess `#cuf.cuda<constant>` and `constant` in fir.global are not really synonym. We can handle this is a follow up patch when we have a real test with the CUDA attribute constant. 

https://github.com/llvm/llvm-project/pull/118582