[flang-commits] [flang] [flang][cuda] Do not register global constants (PR #118582)

[Renaud Kauffmann via flang-commits]

================
@@ -106,8 +106,7 @@ struct CUFAddConstructor
 
         mlir::func::FuncOp func;
         switch (attr.getValue()) {
-        case cuf::DataAttribute::Device:
-        case cuf::DataAttribute::Constant: {
+        case cuf::DataAttribute::Device: {
----------------
Renaud-K wrote:

Yes. So, we should either revisit how `#cuf.cuda<constant>` is applied or how constant fir.global are handled. Whichever change we are going to apply is going to ripple through the flow. What would be the best way to handle it? Maybe we only apply the attribute to reflect the user setting?

https://github.com/llvm/llvm-project/pull/118582