[flang-commits] [flang] fba474d - [flang] Fix CFI_CDESC_T(rank) for C (#66260)

[via flang-commits]

Author: Peter Klausler
Date: 2023-09-18T13:00:42-07:00
New Revision: fba474d3d6af01861b7092ce54ef02609b5b7dbd

URL: https://github.com/llvm/llvm-project/commit/fba474d3d6af01861b7092ce54ef02609b5b7dbd
DIFF: https://github.com/llvm/llvm-project/commit/fba474d3d6af01861b7092ce54ef02609b5b7dbd.diff

LOG: [flang] Fix CFI_CDESC_T(rank) for C (#66260)

The CFI_CDESC_T(rank) macro defined for C (not C++) in
ISO_Fortran_binding.h incorporates a cdesc_t structure as a member,
which works for data layout but doesn't allow for direct access to its
members. (The C++ definition can use inheritance.)

Restructure the definitions in that header file so that
CFI_CDESC_T(rank) for C defines a struct with the expected members.

Added: 
    

Modified: 
    flang/include/flang/ISO_Fortran_binding.h

Removed: 
    


################################################################################
diff  --git a/flang/include/flang/ISO_Fortran_binding.h b/flang/include/flang/ISO_Fortran_binding.h
index e576da753f19400..59e31462ab5aac7 100644
--- a/flang/include/flang/ISO_Fortran_binding.h
+++ b/flang/include/flang/ISO_Fortran_binding.h
@@ -134,15 +134,21 @@ template <typename T> struct FlexibleArray : T {
 #endif
 
 /* 18.5.3 generic data descriptor */
-typedef struct CFI_cdesc_t {
-  /* These three members must appear first, in exactly this order. */
-  void *base_addr;
-  size_t elem_len; /* element size in bytes */
-  int version; /* == CFI_VERSION */
-  CFI_rank_t rank; /* [0 .. CFI_MAX_RANK] */
-  CFI_type_t type;
-  CFI_attribute_t attribute;
+
+/* Descriptor header members */
+#define _CFI_CDESC_T_HEADER_MEMBERS \
+  /* These three members must appear first, \
+   * in exactly this order. */ \
+  void *base_addr; \
+  size_t elem_len; /* element size in bytes */ \
+  int version; /* == CFI_VERSION */ \
+  CFI_rank_t rank; /* [0 .. CFI_MAX_RANK] */ \
+  CFI_type_t type; \
+  CFI_attribute_t attribute; \
   unsigned char f18Addendum;
+
+typedef struct CFI_cdesc_t {
+  _CFI_CDESC_T_HEADER_MEMBERS
 #ifdef __cplusplus
   cfi_internal::FlexibleArray<CFI_dim_t> dim;
 #else
@@ -152,8 +158,9 @@ typedef struct CFI_cdesc_t {
 
 /* 18.5.4 */
 #ifdef __cplusplus
-// The struct below take care of getting the memory storage for C++ CFI_cdesc_t
-// that contain an emulated flexible array.
+// This struct acquires the additional storage, if any is
+// needed, for C++'s CFI_cdesc_t's emulated flexible
+// dim[] array.
 namespace cfi_internal {
 template <int r> struct CdescStorage : public CFI_cdesc_t {
   static_assert((r > 1 && r <= CFI_MAX_RANK), "CFI_INVALID_RANK");
@@ -164,10 +171,10 @@ template <> struct CdescStorage<0> : public CFI_cdesc_t {};
 } // namespace cfi_internal
 #define CFI_CDESC_T(rank) cfi_internal::CdescStorage<rank>
 #else
-#define CFI_CDESC_T(rank) \
+#define CFI_CDESC_T(_RANK) \
   struct { \
-    CFI_cdesc_t cdesc; /* must be first */ \
-    CFI_dim_t dim[rank]; \
+    _CFI_CDESC_T_HEADER_MEMBERS \
+    CFI_dim_t dim[_RANK]; \
   }
 #endif