[flang-commits] [flang] 24d2939 - [flang] Fix portability warning that was incorrectly an "else if"

[Peter Klausler via flang-commits]

Author: Peter Klausler
Date: 2023-07-21T15:34:53-07:00
New Revision: 24d293913c211c43af4d1ab0a23ab66d58aea6df

URL: https://github.com/llvm/llvm-project/commit/24d293913c211c43af4d1ab0a23ab66d58aea6df
DIFF: https://github.com/llvm/llvm-project/commit/24d293913c211c43af4d1ab0a23ab66d58aea6df.diff

LOG: [flang] Fix portability warning that was incorrectly an "else if"

A semantics check for an assumed-length dummy procedure pointer was
inappropriately part of an "else" clause for a preceding check,
causing it to not be applied in all situations.

Differential Revision: https://reviews.llvm.org/D155975

Added: 
    

Modified: 
    flang/lib/Semantics/check-declarations.cpp
    flang/test/Semantics/call01.f90

Removed: 
    


################################################################################
diff  --git a/flang/lib/Semantics/check-declarations.cpp b/flang/lib/Semantics/check-declarations.cpp
index 337f1a0b593017..d9259f40cc309e 100644
--- a/flang/lib/Semantics/check-declarations.cpp
+++ b/flang/lib/Semantics/check-declarations.cpp
@@ -397,7 +397,8 @@ void CheckHelper::Check(const Symbol &symbol) {
         messages_.Say(
             "An assumed-length CHARACTER(*) function cannot return a POINTER"_err_en_US);
       }
-    } else if (IsProcedurePointer(symbol) && IsDummy(symbol)) {
+    }
+    if (IsProcedurePointer(symbol) && IsDummy(symbol)) {
       messages_.Say(
           "A dummy procedure pointer should not have assumed-length CHARACTER(*) result type"_port_en_US);
       // The non-dummy case is a hard error that's caught elsewhere.

diff  --git a/flang/test/Semantics/call01.f90 b/flang/test/Semantics/call01.f90
index 40f7befa223da0..dda1a7f35b1576 100644
--- a/flang/test/Semantics/call01.f90
+++ b/flang/test/Semantics/call01.f90
@@ -118,16 +118,19 @@ character(1) function nested
   end function nested
 end function
 
-subroutine s01(f1, f2, fp1, fp2)
+subroutine s01(f1, f2, fp1, fp2, fp3)
   !PORTABILITY: A dummy procedure pointer should not have assumed-length CHARACTER(*) result type
   character*(*) :: f1, f3, fp1
   external :: f1, f3
-  pointer :: fp1
+  pointer :: fp1, fp3
   !PORTABILITY: A dummy procedure pointer should not have assumed-length CHARACTER(*) result type
   procedure(character*(*)), pointer :: fp2
   interface
     character*(*) function f2()
     end function
+    !PORTABILITY: A dummy procedure pointer should not have assumed-length CHARACTER(*) result type
+    character*(*) function fp3()
+    end function
     !ERROR: A function interface may not declare an assumed-length CHARACTER(*) result
     character*(*) function f4()
     end function