[flang-commits] [PATCH] D142489: [flang] Single entry point for GET_ENVIRONMENT_VARIABLE

[Jean Perier via Phabricator via flang-commits]

jeanPerier added a comment.

There is something broken on windows with the unit test changes (I suspect the windows build bot PATH or some other environment variable may be bigger than what the test expects).
This indeed simplifies lowering and the generated code by removing some generated ifs blocks, so I am happy with this change, although I am not sure it changes anything functionally now since lowering eventually dealt with the optional cases "manually".


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142489/new/

https://reviews.llvm.org/D142489