[flang-commits] [PATCH] D142489: [flang] Single entry point for GET_ENVIRONMENT_VARIABLE

[Leandro Lupori via Phabricator via flang-commits]

luporl added a comment.

AFAIU, having a single entry point for GET_ENVIRONMENT_VARIABLE intrinsic makes it easier to handle dynamically optional arguments correctly.

@jeanPerier explained it in more details in D118777 <https://reviews.llvm.org/D118777>. Lowering was not dealing properly with arguments that may be dynamically optional, that are not known until the runtime.
Splitting the intrinsic in different entry points and returning the length by value pushed some complexity in lowering.

GET_COMMAND_ARGUMENT was already refactored to use a single entry point (D130475 <https://reviews.llvm.org/D130475>).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142489/new/

https://reviews.llvm.org/D142489