[flang-commits] [PATCH] D142124: [flang][hlfir] Lower pointer and allocatable sub-part references

Jean Perier via Phabricator via flang-commits flang-commits at lists.llvm.org
Thu Jan 19 23:58:05 PST 2023


jeanPerier added inline comments.


================
Comment at: flang/lib/Lower/ConvertExprToHLFIR.cpp:258
+    PartInfo partInfo;
+    auto [_, componentType] = visitComponentImpl(component, partInfo);
+    mlir::Type designatorType = fir::ReferenceType::get(componentType);
----------------
PeteSteinfeld wrote:
> I got baffled by this statement.  What's that lone "_" mean?
Fascinating, I was sure that is was a handy way to indicate that one ignore a results in structured-binding (like it is the case in python). But reading at the C++ standard to answer you, it turns out "_" is a legal variable name in C++, so this has no special meaning an you could just use "_" in " _ + _".
Well, thanks for asking, I will just use "componentType = xxx.second" then.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142124/new/

https://reviews.llvm.org/D142124



More information about the flang-commits mailing list