[flang-commits] [PATCH] D142124: [flang][hlfir] Lower pointer and allocatable sub-part references

[Pete Steinfeld via Phabricator via flang-commits]

PeteSteinfeld added a comment.

All builds and tests correctly, and aside from the one nit, looks good.

I don't understand these changes very well, so someone who does should approve.



================
Comment at: flang/lib/Lower/ConvertExprToHLFIR.cpp:258
+    PartInfo partInfo;
+    auto [_, componentType] = visitComponentImpl(component, partInfo);
+    mlir::Type designatorType = fir::ReferenceType::get(componentType);
----------------
I got baffled by this statement.  What's that lone "_" mean?


================
Comment at: flang/lib/Lower/ConvertExprToHLFIR.cpp:311
+      // array ref designates the target (this is done in "visit"). Other
+      // component needs special care to deal with the array%array_comp(indices)
+      // case.
----------------
Should read "components need"


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142124/new/

https://reviews.llvm.org/D142124