[flang-commits] [flang] 5a4171e - [flang] Fix -Wstring-conversion in PPCIntrinsicCall.cpp (NFC)

[Jie Fu via flang-commits]

Author: Jie Fu
Date: 2023-08-11T07:56:01+08:00
New Revision: 5a4171efdf5dcc640de3af5fdfdc8f022af31894

URL: https://github.com/llvm/llvm-project/commit/5a4171efdf5dcc640de3af5fdfdc8f022af31894
DIFF: https://github.com/llvm/llvm-project/commit/5a4171efdf5dcc640de3af5fdfdc8f022af31894.diff

LOG: [flang] Fix -Wstring-conversion in PPCIntrinsicCall.cpp (NFC)

/Users/jiefu/llvm-project/flang/lib/Optimizer/Builder/PPCIntrinsicCall.cpp:1785:16: error: implicit conversion turns string literal into bool: 'const char[21]' to 'bool' [-Werror,-Wstring-conversion]
        assert("invalid element size");
        ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~

Added: 
    

Modified: 
    flang/lib/Optimizer/Builder/PPCIntrinsicCall.cpp

Removed: 
    


################################################################################
diff  --git a/flang/lib/Optimizer/Builder/PPCIntrinsicCall.cpp b/flang/lib/Optimizer/Builder/PPCIntrinsicCall.cpp
index c1c6a2a36326fd..dedaf0b6619b8f 100644
--- a/flang/lib/Optimizer/Builder/PPCIntrinsicCall.cpp
+++ b/flang/lib/Optimizer/Builder/PPCIntrinsicCall.cpp
@@ -1782,10 +1782,10 @@ void PPCIntrinsicLibrary::genVecStore(llvm::ArrayRef<fir::ExtendedValue> args) {
         fname = "llvm.ppc.altivec.stvewx";
         break;
       default:
-        assert("invalid element size");
+        assert(false && "invalid element size");
       }
     } else
-      assert("unknown type");
+      assert(false && "unknown type");
     break;
   }
   default:
@@ -1892,7 +1892,7 @@ void PPCIntrinsicLibrary::genVecXStore(
                                 addr);
     break;
   default:
-    assert("Invalid vector operation for generator");
+    assert(false && "Invalid vector operation for generator");
   }
   builder.create<fir::StoreOp>(loc, mlir::TypeRange{},
                                mlir::ValueRange{src, trg},