[flang-commits] [PATCH] D136606: [flang] Fix building against clang dylib

[Michał Górny via Phabricator via flang-commits]

mgorny added a comment.

In D136606#3879466 <https://reviews.llvm.org/D136606#3879466>, @awarzynski wrote:

> Hey @mgorny , thanks for working on this
>
> I thought that this build configuration is actually tested by flang-aarch64-dylib <https://lab.llvm.org/buildbot/#/builders/177>, so I'm not sure why it fails for you. I suspect that you only have `libclang.dylib` available on your system? And the buildbot would still build `libClangBasic.so/a` as a separate library?

Yes, we don't install static clang libraries on Gentoo, and the buildbot probably has them (since the targets are present when doing in-tree build).



================
Comment at: flang/lib/FrontendTool/CMakeLists.txt:18
+
+if(TARGET clangBasic)
+  add_dependencies(flangFrontendTool clangBasic)
----------------
awarzynski wrote:
> Where is `TARGET` defined? Please bear with me - I'm confused that in Flang (which only defines Flang CMake targets) we would be checking whether "target" is a particular Clang target?
Unless I'm mistaken, if you're doing in-tree build of LLVM + Clang + Flang, then targets from other projects should be visible here. FWICS LLVM is ensuring that Clang is processed prior to Flang in all cases, so it should work.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136606/new/

https://reviews.llvm.org/D136606