[flang-commits] [PATCH] D136606: [flang] Fix building against clang dylib

Mon Oct 24 08:10:02 PDT 2022

awarzynski added a comment.

Hey @mgorny , thanks for working on this

I thought that this build configuration is actually tested by flang-aarch64-dylib <https://lab.llvm.org/buildbot/#/builders/177>, so I'm not sure why it fails for you. I suspect that you only have `libclang.dylib` available on your system? And the buildbot would still build `libClangBasic.so/a` as a separate library?

================
Comment at: flang/lib/FrontendTool/CMakeLists.txt:18
+
+if(TARGET clangBasic)
+  add_dependencies(flangFrontendTool clangBasic)
----------------
Where is `TARGET` defined? Please bear with me - I'm confused that in Flang (which only defines Flang CMake targets) we would be checking whether "target" is a particular Clang target?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136606/new/

https://reviews.llvm.org/D136606