[flang-commits] [PATCH] D135959: [flang] Introduce option to lower expression to HLFIR

Mon Oct 17 00:52:16 PDT 2022

jeanPerier added a comment.

In D135959#3858615 <https://reviews.llvm.org/D135959#3858615>, @DavidTruby wrote:

> Good to see HLFIR getting going! Do you have a plan to support this in the `flang-new` driver as well as bbc?

Yes, when there is some end-to-end support for this new path, I will add a way to control the option in flang-new too.

In D135959#3858896 <https://reviews.llvm.org/D135959#3858896>, @PeteSteinfeld wrote:

> It looks to me like references to the data member `lowerToHighLevelFIR` should be made consistent.

The members `LoweringOptions` were previously added as bit-fields (https://en.cppreference.com/w/cpp/language/bit_field), so making the new one a bool would be inconsistent.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135959/new/

https://reviews.llvm.org/D135959