[flang-commits] [PATCH] D135959: [flang] Introduce option to lower expression to HLFIR

[Thorsten via Phabricator via flang-commits]

tschuett added a comment.

In D135959#3858896 <https://reviews.llvm.org/D135959#3858896>, @PeteSteinfeld wrote:

> It looks to me like references to the data member `lowerToHighLevelFIR` should be made consistent.





================
Comment at: flang/include/flang/Lower/LoweringOptions.h:29
+  /// Off by default until fully ready.
+  unsigned lowerToHighLevelFIR : 1;
+
----------------
PeteSteinfeld wrote:
> Shouldn't this be `bool` rather than `unsigned`?
IIRC, MSVC does not like mixed bitfields.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135959/new/

https://reviews.llvm.org/D135959