[flang-commits] [PATCH] D122441: [flang] Add & use a better visit()

[Andrzej Warzynski via Phabricator via flang-commits]

awarzynski added a subscriber: Leporacanthicus.
awarzynski added a comment.

Thanks Diana, this was indeed reverted in good faith. I appreciate that this can be frustrating, but with such a high traffic and so many developers working on this project, reverting is the most reliable way to address such issues in a timely fashion. @klausler, please don't abandon this patch. Given the time difference between us, it can be tricky to coordinate (IIUC, that's one of the reasons for the revert policy to be so liberal).

We did some more digging and it looks like a Clang 13 issue. On AArch64, both Clang 12 and Clang 14 are fine. I believe that @Leporacanthicus was also able to reproduce this with Clang 13 on X86.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122441/new/

https://reviews.llvm.org/D122441