[flang-commits] [PATCH] D122441: [flang] Add & use a better visit()

[Diana Picus via Phabricator via flang-commits]

rovka added a comment.

In D122441#3411723 <https://reviews.llvm.org/D122441#3411723>, @klausler wrote:

> The change could have been disabled easily in one place with a #define -- it was protected by #ifdefs.  You should not have reverted all of it without consulting me.  I will not waste any more time trying to push it into llvm.

@klausler: I can't speak for Andrzej, but I think his revert was conforming to the (admittedly aggressive) LLVM revert policy <https://llvm.org/docs/DeveloperPolicy.html#patch-reversion-policy>. A revert is not meant as an affront, and in general it's preferred to revert and recommit with a fix than to commit just a fix later on (this makes it easier for people to backport patches into e.g. the release branch or downstream branches without having to chase follow-up fixes). We also try really hard to bring the buildbots back to green as soon as possible, because if someone else breaks something while the bots are already red, they won't get a notification and it will be much more difficult to track down the issue (it basically means the person who committed the second red patch won't be aware that they broke something, and it will be down to the buildbot owner to notice that the CI is red and waste a lot of time trying to figure out what's going on; this also tends to get a nasty snowball effect). Because of this urgency it's considered good practice to revert someone else's patch if they don't do it themselves after some arbitrary amount of time (and especially if you know they're on a different timezone and suspect they might be offline).

TL;DR: I think this is just a misunderstanding, please don't abandon the patch because of it. My personal impression is that Andrzej was acting in good faith here, according to the norms and habits of the wider LLVM community.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122441/new/

https://reviews.llvm.org/D122441