[flang-commits] [PATCH] D122441: [flang] Add & use a better visit()

[Andrzej Warzynski via Phabricator via flang-commits]

awarzynski added a comment.

Thanks for this patch. I will need to revert it for now as it's causing multiple buildbots to fail:

- flang-aarch64-dylib <https://lab.llvm.org/buildbot/#/builders/177/builds/4346>
- flang-aarch64-latest-clang <https://lab.llvm.org/buildbot/#/builders/180/builds/3803>
- flang-aarch64-out-of-tree <https://lab.llvm.org/buildbot/#/builders/175/builds/10419>
- flang-aarch64-rel-assert <https://lab.llvm.org/buildbot/#/builders/191/builds/4318>
- flang-aarch64-release <https://lab.llvm.org/buildbot/#/builders/173/builds/4274>
- flang-aarch64-sharedlibs <https://lab.llvm.org/buildbot/#/builders/181/builds/4297>

All of these buildbots run on AArch64 and use Clang. I can confirm that there are no issues when:

- building on X86 (tested with GCC 9.3 and Clang 12)
- building on AArch64 with GCC (tested with GCC 11)

AFAIK, there's no pre-merge CI for AArch64, but I can test this manually for you once a fix is available. One other option is to change this to "opt-in", but I'm not a fan.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122441/new/

https://reviews.llvm.org/D122441