[flang-commits] [flang] f5b29a7 - [flang][NFC] Add todo in CallInterface

[Valentin Clement via flang-commits]

Author: Valentin Clement
Date: 2022-03-14T10:42:52+01:00
New Revision: f5b29a7a9669fbfd0424e799631419b183bd681e

URL: https://github.com/llvm/llvm-project/commit/f5b29a7a9669fbfd0424e799631419b183bd681e
DIFF: https://github.com/llvm/llvm-project/commit/f5b29a7a9669fbfd0424e799631419b183bd681e.diff

LOG: [flang][NFC] Add todo in CallInterface

Add a todo for assumed shape dummy argument with VALUE attribute
since this is not implemented yet.

This patch is part of the upstreaming effort from fir-dev branch.

Reviewed By: jeanPerier

Differential Revision: https://reviews.llvm.org/D121581

Added: 
    

Modified: 
    flang/lib/Lower/CallInterface.cpp

Removed: 
    


################################################################################
diff  --git a/flang/lib/Lower/CallInterface.cpp b/flang/lib/Lower/CallInterface.cpp
index 241a6adc0a88f..adb6593902fb6 100644
--- a/flang/lib/Lower/CallInterface.cpp
+++ b/flang/lib/Lower/CallInterface.cpp
@@ -836,6 +836,8 @@ class Fortran::lower::CallInterfaceImpl {
       addPassedArg(PassEntityBy::MutableBox, entity, characteristics);
     } else if (dummyRequiresBox(obj)) {
       // Pass as fir.box
+      if (isValueAttr)
+        TODO(loc, "assumed shape dummy argument with VALUE attribute");
       addFirOperand(boxType, nextPassedArgPosition(), Property::Box, attrs);
       addPassedArg(PassEntityBy::Box, entity, characteristics);
     } else if (dynamicType.category() ==