[flang-commits] [PATCH] D121171: [flang] Add ExternalNameConversionPass to flang-new pipeline

[Eric Schweitz via Phabricator via flang-commits]

schweitz added a comment.

The internal mangling is stable. Target-specific mangling is not. We don't want to write all tests that get top heavy and tricky to maintain dealing with distractions like target conformance and compatibility rather than focusing on what they ought to be testing.



================
Comment at: flang/test/Lower/Intrinsics/abs.f90:2
 ! RUN: bbc -emit-fir %s -o - | FileCheck %s
 ! RUN: %flang_fc1 -emit-fir %s -o - | FileCheck %s
 
----------------
Why does this test need to be run with flang?

We don't see the LLVM tests being driven by both opt and clang.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121171/new/

https://reviews.llvm.org/D121171