[flang-commits] [PATCH] D126291: [flang][Driver] Update link job on windows

[Martin Storsjö via Phabricator via flang-commits]

mstorsjo added a comment.

In D126291#3573937 <https://reviews.llvm.org/D126291#3573937>, @mmuetzel wrote:

> Ah ok. So instead of having `! REQUIRES:` lines, those tests should add `-target x86_64-windows-msvc` to the flang invocation?

Exactly

> On platforms that didn't build the necessary libraries (e.g., a GNU system not explicitly configured to build a cross-compiler for that target), linking will likely fail. I don't know what `FileCheck` is doing. Can it cope with that?

These tests don't try to run the full link command - the `-###` parameter means that it only prints what subcommands it would have executed. So on any system, you can run the codepath in clang that just prints that it should execute `link ... Fortran_main.lib`, even if `Fortran_main.lib` doesn't actually exist. This is the basis of how all of LLVM's shell tests work - you don't need to be able to execute the full compiler toolchain, but you can verify that each individual step does what it's supposed to do.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126291/new/

https://reviews.llvm.org/D126291