[flang-commits] [PATCH] D126291: [flang][Driver] Update link job on windows

[Markus Mützel via Phabricator via flang-commits]

mmuetzel added a comment.

In D126291#3573751 <https://reviews.llvm.org/D126291#3573751>, @mstorsjo wrote:

> Maybe, but keep in mind that those kinds of tests should be the exception, not the rule.
>
> As clang (and flang too, I would presume) generally can be cross compiling, one shouldn't imply that you need to be running on windows, to be able to test how the clang driver behaves when targeting windows. You can test that on any system, by passing `-target x86_64-windows-msvc` to the e.g. clang command in a lit test, so you can get test coverage for that aspect of the functionality regardless of what system you're running. Most tests in `clang/test/Driver` work that way.

Ah ok. So instead of having `! REQUIRES:` lines, those tests should add `-target x86_64-windows-msvc` to the flang invocation?
On platforms that didn't build the necessary libraries (e.g., a GNU system not explicitly configured to build a cross-compiler for that target), linking will likely fail. I don't know what `FileCheck` is doing. Can it cope with that?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126291/new/

https://reviews.llvm.org/D126291