[flang-commits] [flang] 4640a8a - [NFC][flang] Add FIXME for privatization of loop bounds in Bridge.cpp

[Peixin Qiao via flang-commits]

Author: Peixin Qiao
Date: 2022-07-27T23:37:55+08:00
New Revision: 4640a8a22cbae50c03c5f41d145916258a17a491

URL: https://github.com/llvm/llvm-project/commit/4640a8a22cbae50c03c5f41d145916258a17a491
DIFF: https://github.com/llvm/llvm-project/commit/4640a8a22cbae50c03c5f41d145916258a17a491.diff

LOG: [NFC][flang] Add FIXME for privatization of loop bounds in Bridge.cpp

There is post comment of adding TODO/FIXME for privatization of loop
bounds in D127137. D127137 fixes the bug in OpenMP firstprivate clause,
which should be refactored later according to the post comment. Add
FIXME for it.

Differential Revision: https://reviews.llvm.org/D130625

Added: 
    

Modified: 
    flang/lib/Lower/Bridge.cpp

Removed: 
    


################################################################################
diff  --git a/flang/lib/Lower/Bridge.cpp b/flang/lib/Lower/Bridge.cpp
index 5a5cfe56be98..5d88d20f931a 100644
--- a/flang/lib/Lower/Bridge.cpp
+++ b/flang/lib/Lower/Bridge.cpp
@@ -478,6 +478,7 @@ class FirConverter : public Fortran::lower::AbstractConverter {
     // new copied value.
     // Not able to use replaceAllUsesWith() because uses outside
     // the loop body should not use the clone.
+    // FIXME: Call privatization before the loop operation.
     mlir::Region &curRegion = getFirOpBuilder().getRegion();
     mlir::Value oldVal = fir::getBase(hexv);
     mlir::Value cloneVal = fir::getBase(exv);