[flang-commits] [PATCH] D128261: [Fortran] Relax relative tolerance for FCVS tests

Diana Picus via Phabricator via flang-commits flang-commits at lists.llvm.org
Wed Jul 27 03:07:29 PDT 2022


rovka added a comment.

In D128261#3681547 <https://reviews.llvm.org/D128261#3681547>, @sscalpone wrote:

> My preference is that the reference output match the output of flang with the default settings.   Would that work with the gfortran + the provided FP_TOLERANCE?   The consensus was not to include fcvs in the llvm-project tree; we can revisit that decision if you'd like to start a thread in discourse or on of the weekly calls.
>
> Regarding FP_TOLERANCE: We know that precision varies not only from compiler to compiler but also when using different command-line options.   Again, my preference would be to have the committed files match flang with its default options.    When testing other compilers, or other option sets, the appropriate value could be supplied through CMake.

Ok, thanks for chiming in! I'm just going to update the reference outputs to match what flang does, and we can worry about gfortran later.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128261/new/

https://reviews.llvm.org/D128261



More information about the flang-commits mailing list