[flang-commits] [PATCH] D130475: [flang] Single entry point for GET_COMMAND_ARGUMENT

[Jean Perier via Phabricator via flang-commits]

jeanPerier accepted this revision.
jeanPerier added a comment.
This revision is now accepted and ready to land.

Thanks a lot for following up on this. Beware that there is a test failure introduced in Runtime/no-cpp-dep.c (I think you need to remove the references to the removed runtime APIs there).
Otherwise LGTM.



================
Comment at: flang/lib/Lower/IntrinsicCall.cpp:772
+       {"length", asBox, handleDynamicOptional},
        {"status", asAddr},
        {"errmsg", asBox, handleDynamicOptional}}},
----------------
STATUS is also optional, I think it also needs to have `handleDynamicOptional` so that the OPTIONAL POINTER/OPTIONAL ALLOCATABLE edge case are handled correctly (I think the current code might unconditionally dereference the descriptor in these case).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130475/new/

https://reviews.llvm.org/D130475