[flang-commits] [PATCH] D128261: [Fortran] Relax relative tolerance for FCVS tests

[Peter Klausler via Phabricator via flang-commits]

klausler added a comment.

In D128261#3677312 <https://reviews.llvm.org/D128261#3677312>, @Meinersbur wrote:

> My conclusion is different. If gfortran's output is correct according to the Fortran standard, it should pass the test as well. Running the test-suite with other compilers than Clang/Flang was always helpful in testing the integrity of the tests themselves.

Standards often have implementation-dependent features; Fortran I/O is chock full of them, especially in the area of list-directed output.  Standard-conforming implementations can produce quite distinct output from standard-conforming programs.

So you can relax tolerances for comparison and make this copy of FCVS more useful for testing multiple Fortran compilers, or you can install f18-specific output files and be more useful for catching inadvertent changes to output, but I don't think that you can do both.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128261/new/

https://reviews.llvm.org/D128261