[flang-commits] [PATCH] D130166: [flang] Adding a guideline for flang design documentation

[Kiran Chandramohan via Phabricator via flang-commits]

kiranchandramohan added a comment.

In D130166#3668985 <https://reviews.llvm.org/D130166#3668985>, @jeanPerier wrote:

> In D130166#3668764 <https://reviews.llvm.org/D130166#3668764>, @kiranchandramohan wrote:
>
>> I like the idea of good design docs. We should have something like this for OpenMP as well. The only difficulty is that the OpenMP dialect and OpenMP IRBuilder sit outside the flang tree and can be worked on independently.  So maybe any such discussions can be in discourse but before implementation in Flang (parse-tree to OpenMP + FIR dialects) we can make this a requirement for OpenMP as well subject to agreement of this proposal and consensus among OpenMP team members.
>
> Good point, what about adding:
>
> Features impacting projects outside of flang (like work OpenMP or OpenACC that may require touching parts outside of flang tree) should follow the general LLVM process, or the related subproject process. There should still be a related flang design docs if part of the solution impacts flang in significant way (e.g. it involves changes in the lowering from the parse-tree to OpenMP or FIR dialects that are not simply about mapping a parse-tree node to a related dialect operation).

+1


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130166/new/

https://reviews.llvm.org/D130166