[flang-commits] [PATCH] D130166: [flang] Adding a guideline for flang design documentation

[Andrzej Warzynski via Phabricator via flang-commits]

awarzynski added inline comments.


================
Comment at: flang/docs/DesignGuideline.md:18
+
+When working on a new feature in flang, some design document should
+be produced before submitting patches to the code.
----------------
Can you clarify what you mean by "a new feature"? What changes are expected to come with a design doc?


================
Comment at: flang/docs/DesignGuideline.md:31-33
+ideally using the name of the feature as the document name. Its approval on
+Phabricator is the pre-requisite to submitting patches implementing new
+features.
----------------
IMHO, we should make sure that every new design doc is well advertised, so that everyone who is interested can participate in the discussion. In this respect, Discourse is much more inclusive than Phabricator and posting there should be required rather than optional (as suggested in the following paragraph).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130166/new/

https://reviews.llvm.org/D130166