[flang-commits] [PATCH] D129788: Lower F08 parity intrinsic

[Jean Perier via Phabricator via flang-commits]

jeanPerier added inline comments.


================
Comment at: flang/lib/Lower/IntrinsicCall.cpp:851
+     &I::genParity,
+     {{{"mask", asAddr}, {"dim", asValue}}},
+     /*isElemental=*/false},
----------------
I think you should use `asBox` here, using `asAddr` will force non contiguous masks to be evaluated into a contiguous temp before calling the runtime, and this is probably some choice we should leave to the runtime.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129788/new/

https://reviews.llvm.org/D129788