[flang-commits] [PATCH] D129616: Lower F08 bitwise-reduction intrinsics (IALL, IANY, IPARITY)

[Jean Perier via Phabricator via flang-commits]

jeanPerier added a comment.

Thanks a lot for plugging all that runtime. Apart from the KIND 16 issue in the fir::runtime::genXXX, this looks great to me.



================
Comment at: flang/lib/Optimizer/Builder/Runtime/Reduction.cpp:953
+  else if (eleTy.isInteger(builder.getKindMap().getIntegerBitsize(16)))
+    func = fir::runtime::getRuntimeFunc<mkRTKey(IAll16)>(loc, builder);
+  else
----------------
Currently, the 128 bits case need to be manually defined because the runtime declaration are not accessible on all hosts (see the windows bot failure). See `ForcedMinvalInteger16` for an example of how to manually define it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129616/new/

https://reviews.llvm.org/D129616