[flang-commits] [PATCH] D129156: Add -fpass-plugin option to Flang

[Andrzej Warzynski via Phabricator via flang-commits]

awarzynski added a comment.



In D129156#3647064 <https://reviews.llvm.org/D129156#3647064>, @tarunprabhu wrote:

> It seems as if the `Bye` pass will only print a message when the `-wave-goodbye` flag is passed to it. But I don't know of a way to pass that flag to the pass when loading the pass using `-fpass-plugin`. If not, is there a way, with the new pass manager, to print the list of passes that were executed?

You can use `-fdebug-pass-manager`, see e.g. here <https://github.com/llvm/llvm-project/blob/main/flang/test/Driver/default-optimization-pipelines.f90#L3>.

In D129156#3642328 <https://reviews.llvm.org/D129156#3642328>, @tarunprabhu wrote:

> Ok. It shouldn't be too difficult to create a patch for that. I suppose I
> can add one and see what the clang community has to say about it.

You can do it in this patch. It's going to be a small change.

> True, but even with actions, there may be those that would benefit from not failing immediately.

We haven't identified a specific case in which //not failing immediately// would be desirable. I'm fine with the current approach, but would appreciate if consistency with Clang was emphasized (either in the commit message or as a comment, preferably both).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129156/new/

https://reviews.llvm.org/D129156