[flang-commits] [PATCH] D114134: [flang] Add co_sum to the list of intrinsics and update test

[Katherine Rasmussen via Phabricator via flang-commits]

ktras reopened this revision.
ktras added a comment.
This revision is now accepted and ready to land.

I pushed this change today and had to revert the commit because it caused some unexpected test failures. The three tests that failed on the buildbots (though these tests didn't consistently fail across the different buildbots) were all flang semantics tests and are:

- `flang/test/Semantics/collective01.f90` - the test that I removed the `XFAIL` directive from in this differential
- `flang/test/Semantics/move_alloc.f90` - the new test from this differential
- `flang/test/Semantics/doconcurrent01.f90` - a test that I do not yet understand why it was impacted by this differential

I added the additional specific checks for `co_sum` and `move_alloc` to `ApplySpecificChecks()`, but because previously, `ApplySpecificChecks()` was only called if the intrinsic procedure was a function, I had to add another call to `ApplySpecificChecks()` in the case of an intrinsic subroutine. I thought that that addition was fairly straightforward and the tests passed locally on my machine, but I am wondering if that addition is not as straightforward as I thought and that there were unintended consequences that might be contributing to these unexpected test failures. I am trying to track down what is going on, whether it is related to the way I added the call to `ApplySpecificChecks()` or if it is related to my other changes in the differential, but if there is anything that jumps out at anyone, I would appreciate the feedback.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114134/new/

https://reviews.llvm.org/D114134