[flang-commits] [PATCH] D129584: Lower F08 bit-population count intrinsics

[Kiran Chandramohan via Phabricator via flang-commits]

kiranchandramohan added inline comments.


================
Comment at: flang/test/Lower/Intrinsics/leadz.f90:1
+! RUN: bbc -emit-fir %s -o - | FileCheck %s
+
----------------
tarunprabhu wrote:
> kiranchandramohan wrote:
> > kiranchandramohan wrote:
> > > Nit: Could you add the flang driver also for tests.
> > Apologies, I was requesting flang driver tests in addition. You may add `bbc` back when you submit.
> Could you clarify what you mean by this?
I meant having tests with the driver as well as `bbc` like the test https://github.com/llvm/llvm-project/blob/main/flang/test/Lower/Intrinsics/exp.f90.
```
! RUN: bbc -emit-fir %s -o - | FileCheck %s
! RUN: %flang_fc1 -emit-fir %s -o - | FileCheck %s
```

The second part is applicable if you finally use `git push` to submit. Then you do not need to create another revision in phabricator for review. You can fetch this patch. Add the RUN like for bbc, rebase and then submit using `git push`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129584/new/

https://reviews.llvm.org/D129584