[flang-commits] [PATCH] D128009: [flang] Add semantics test for image_status and add a check

[Peter Klausler via Phabricator via flang-commits]

klausler added inline comments.


================
Comment at: flang/lib/Evaluate/intrinsics.cpp:2353
+              std::visit(common::visitors{
+                             [&](const Constant<Type<TypeCategory::Integer, 1>>
+                                     &array) {
----------------
Please don't copy-and-paste code for each currently supported kind of integer.  Use an abstraction that covers all of them.


================
Comment at: flang/lib/Evaluate/intrinsics.cpp:2390
+        context.messages().Say(arg.sourceLocation(),
+            "'%s=' argument for intrinsic '%s' must be a positive value"_err_en_US,
+            argName, procName);
----------------
`"'%s=' argument for intrinsic function '%s' must be a positive value, but is %jd"_err_en_US, argName, procName, static_cast<std::intmax_t>(*val)`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128009/new/

https://reviews.llvm.org/D128009