[flang-commits] [PATCH] D128009: [flang] Add semantics test for image_status and add a check

[Katherine Rasmussen via Phabricator via flang-commits]

ktras added a comment.

@klausler I did try to come up with an error message that included the actual value that was passed, but I couldn't come up with any message that was concise or that I liked better than the current error message. I am of course open to suggestions. And thank you for your feedback on the better way to access the object inside of an `std::optional`.

@jeanPerier Thank you for your helpful suggestions on how to unpack the `Expr<SomeType>` if it was an array. I have unpacked it now and was able to provide an error message if a non positive value is included in the array. There might be a more elegant way to deal with all of the different `kinds`, but this is what I have come up with for now.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128009/new/

https://reviews.llvm.org/D128009