[flang-commits] [PATCH] D127805: Bitwise comparison intrinsics

vdonaldson via Phabricator via flang-commits flang-commits at lists.llvm.org
Tue Jul 5 13:33:30 PDT 2022


vdonaldson added inline comments.


================
Comment at: flang/lib/Lower/IntrinsicCall.cpp:1866
 
+// BGE, BGT, BLE, BLT
+template <mlir::arith::CmpIPredicate pred>
----------------
Thanks for simplifying these definitions.  Most of these intrinsics are placed alphabetically.  It would be nice to follow that here, and move these down between AINT and BTEST


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127805/new/

https://reviews.llvm.org/D127805



More information about the flang-commits mailing list