[flang-commits] [PATCH] D129018: [flang] Establish a single source of target information for semantics

Thorsten via Phabricator via flang-commits flang-commits at lists.llvm.org
Sat Jul 2 09:11:39 PDT 2022


tschuett added a comment.

>From a design point, I would have expected an abstract base class. Targets can implement it in any way they wish. Maybe the driver is better place for target-specific information. Then you can have a factory method with the target target triple.

There was a discussion that Flang should have used comdats:
https://reviews.llvm.org/D127455


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129018/new/

https://reviews.llvm.org/D129018



More information about the flang-commits mailing list