[flang-commits] [PATCH] D119555: [flang] Fail at link time if derived type descriptors were not generated

[Peter Klausler via Phabricator via flang-commits]

klausler accepted this revision.
klausler added inline comments.
This revision is now accepted and ready to land.


================
Comment at: flang/include/flang/Common/builtin-modules.h:1
+//===-- include/flang/Common/builtin-modules.h ------------------*- C++ -*-===//
+//
----------------
I'm not sure that /Common is the right place for this -- the name could be defined in semantics and referenced from lowering via the SemanticsContext.


================
Comment at: flang/include/flang/Semantics/symbol.h:509
       InNamelist, // in a Namelist group
+      // A compiler created symbol
       CompilerCreated,
----------------
Could go on the same line


================
Comment at: flang/include/flang/Semantics/symbol.h:512
+      // For compiler created symbol that are constants but  cannot legally have
+      // the PARAMETER.
+      ReadOnly,
----------------
"the PARAMETER attribute."


================
Comment at: flang/lib/Semantics/runtime-type-info.cpp:251
+  // PARAMETER attribute (the main issue is that they may be TARGET, and normal
+  // FORTRAN parameters cannot be TARGETs).
+  if (symbol.has<semantics::ObjectEntityDetails>() ||
----------------
Fortran


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119555/new/

https://reviews.llvm.org/D119555