[flang-commits] [PATCH] D140310: [flang] Finish substring lowering

[Pete Steinfeld via Phabricator via flang-commits]

PeteSteinfeld accepted this revision.
PeteSteinfeld added a comment.
This revision is now accepted and ready to land.

Other than the one nit, all builds and tests correctly and looks good.



================
Comment at: flang/lib/Lower/ConvertExprToHLFIR.cpp:178-181
+    if (cstLen) {
+      partInfo.typeParams[0] =
+          builder.createIntegerConstant(loc, idxTy, *cstLen);
+    } else {
----------------
Braces aren't needed for the "then" part of this "if".


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140310/new/

https://reviews.llvm.org/D140310