[flang-commits] [PATCH] D140220: [flang] Lower statement function references in HLFIR

[Pete Steinfeld via Phabricator via flang-commits]

PeteSteinfeld added a comment.

Aside from a couple of nits, all builds and tests correctly and looks good.  @vdonaldson should take a look, though.



================
Comment at: flang/lib/Lower/Bridge.cpp:452
                          Fortran::lower::SymbolRef target) override final {
-    localSymbols.addSymbol(target, lookupSymbol(src).toExtendedValue());
+    if (bridge.getLoweringOptions().getLowerToHighLevelFIR()) {
+      localSymbols.addVariableDefinition(
----------------
I don't think you need the curly braces here.


================
Comment at: flang/lib/Lower/ConvertCall.cpp:419
+  // Statement functions have their own scope, we just need to associate
+  // the dummy symbols to argument expressions. They are no
+  // optional/alternate return arguments. Statement functions cannot be
----------------
Did you mean to say "There are no"


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140220/new/

https://reviews.llvm.org/D140220