[flang-commits] [PATCH] D140134: [flang] Expunge needless semantics::ProcInterface

[Pete Steinfeld via Phabricator via flang-commits]

PeteSteinfeld added a comment.

In D140134#4000527 <https://reviews.llvm.org/D140134#4000527>, @jeanPerier wrote:

> I feel sorry to bother you here because there is something odd with clang-format that is a bit unrelated to your patch.
> My top of the tree clang-format agrees with the formatting of your patch, but the build bot clang format (and @PeteSteinfeld's clang-format).
>
> I had a similar issue in one of my patch, it seems my clang-format and yours want the "*" in `if (const Symbol *interface{proc.procInterface()})` next to the variable name (which makes more sense IMHO), while the build bot clang-format (and older clang format I could test) wants the "*" in the middle of two spaces `if (const Symbol * interface{proc.procInterface()})`. Given most of flang codebase is using the latter style, it may be better to stick with it, especially if it still is what the build bot expects.

I'm not sure if this is documented anywhere, but I believe that the version of clang-format that the build bots use gets built from the latest released sources.  The latest released version of llvm has the tag "llvmorg-15.0.6".  I'd guess that if you build clang-format from that release, you'll match the build bots.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140134/new/

https://reviews.llvm.org/D140134