[flang-commits] [PATCH] D140093: [flang] hlfir.elemental codegen

[Pete Steinfeld via Phabricator via flang-commits]

PeteSteinfeld added a comment.

Aside from a couple of nits, all builds and tests correctly and looks good as far as I can tell.  But someone with more expertise should approve.



================
Comment at: flang/include/flang/Optimizer/Builder/HLFIRTools.h:265
+/// Inline the body of an hlfir.elemental at the current insertion point
+/// given a list of one based indices. This generate the computation
+/// of one element of the elemental expression. Return the YieldElementOp
----------------
"generates" rather than "generate"


================
Comment at: flang/lib/Optimizer/HLFIR/Transforms/BufferizeHLFIR.cpp:307
+/// This Listener allows setting both the builder and the rewriter as
+/// listeners. This is required when a patterns uses a firBuilder helper that
+/// may create illegal operations that will need to be translated and required
----------------
"patterns" should read "pattern"


================
Comment at: flang/lib/Optimizer/HLFIR/Transforms/BufferizeHLFIR.cpp:308
+/// listeners. This is required when a patterns uses a firBuilder helper that
+/// may create illegal operations that will need to be translated and required
+/// notifying the rewriter.
----------------
"required" should read "requires"


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140093/new/

https://reviews.llvm.org/D140093