[flang-commits] [PATCH] D140134: [flang] Expunge needless semantics::ProcInterface

[Peter Klausler via Phabricator via flang-commits]

klausler created this revision.
klausler added a reviewer: jeanPerier.
klausler added a project: Flang.
Herald added a subscriber: jdoerfert.
Herald added a reviewer: sscalpone.
Herald added a project: All.
klausler requested review of this revision.

The ProcInterface structure is used only by ProcEntityDetails; it represents 
what a program might have put in parentheses in a procedure-declaration-stmt,
either the name of a procedure interface or a declaration-type-spec.

If a procedure entity has an implicit interface, the function result   
type (if any) can be kept in EntityDetails::type_, which already exists
and is currently redundant for ProcEntityDetails symbols.

All that is really needed is a nullable Symbol pointer in ProcEntityDetails
to point to the procedure's explicit interface, when it has one.

Also, catch the case where a procedure has an explicit interface
and a program attempts to also give it a type.


https://reviews.llvm.org/D140134

Files:
  flang/include/flang/Evaluate/characteristics.h
  flang/include/flang/Semantics/symbol.h
  flang/include/flang/Semantics/type.h
  flang/lib/Evaluate/call.cpp
  flang/lib/Evaluate/characteristics.cpp
  flang/lib/Evaluate/shape.cpp
  flang/lib/Evaluate/tools.cpp
  flang/lib/Semantics/check-declarations.cpp
  flang/lib/Semantics/mod-file.cpp
  flang/lib/Semantics/resolve-names-utils.cpp
  flang/lib/Semantics/resolve-names.cpp
  flang/lib/Semantics/symbol.cpp
  flang/lib/Semantics/tools.cpp
  flang/lib/Semantics/type.cpp
  flang/test/Semantics/procinterface03.f90

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D140134.483255.patch
Type: text/x-patch
Size: 27411 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/flang-commits/attachments/20221215/10fe6ed1/attachment-0001.bin>